feat(devtools): extract theme to devtool components#366
feat(devtools): extract theme to devtool components#366harry-whorlow wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 4842956 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a ThemeContextProvider and theme prop to the Devtools component, restores image-gen routes in the generated route types, and bumps Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 4842956
☁️ Nx Cloud last updated this comment at |
|
do note merge till TanStack/devtools#386 is merged, it won't build anyways 😄... |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/moody-wings-type.md:
- Line 5: Replace the typo "miss-match" with the correct single-word "mismatch"
in the changeset text (search for the string "miss-match" in
.changeset/moody-wings-type.md and update it to "mismatch") so the sentence
reads "Moves devtools theme to the component to avoid theme mismatch."
In `@packages/typescript/ai-devtools/src/components/Shell.tsx`:
- Around line 1-6: The named imports from 'solid-js' are not in the order
required by the sort-imports rule; reorder the import specifiers so they are
alphabetically sorted (adjust the placement of ThemeContextProvider among
createSignal, onCleanup and onMount) so the import list in Shell.tsx satisfies
the linter.
- Around line 5-7: The import of ThemeContextProvider from 'solid-js' is
invalid; remove ThemeContextProvider from the solid-js import list and either
import the actual provider from its correct package (e.g., the real source or a
package like `@solid-primitives/context`) or create a local provider using
createContext() and export a ThemeContextProvider wrapper used by the Shell
component; update any usage of ThemeContextProvider in this file to the newly
imported/defined provider so the build no longer fails.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: af840485-8d5a-4699-852f-dc1fb9e8dbfb
📒 Files selected for processing (2)
.changeset/moody-wings-type.mdpackages/typescript/ai-devtools/src/components/Shell.tsx
@tanstack/ai
@tanstack/ai-anthropic
@tanstack/ai-client
@tanstack/ai-devtools-core
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-groq
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-openrouter
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
Moves devtool theme from the utils to the component to avoid the theme miss-match error.
Summary by CodeRabbit
New Features
Bug Fixes
New Routes
Chores